BASH: Clean up, Compartmentalize, and auto-detect if in project root.#1
Open
TheFlagCourier wants to merge 3 commits intoGodotCommunityGamesOrg:mainfrom
Open
BASH: Clean up, Compartmentalize, and auto-detect if in project root.#1TheFlagCourier wants to merge 3 commits intoGodotCommunityGamesOrg:mainfrom
TheFlagCourier wants to merge 3 commits intoGodotCommunityGamesOrg:mainfrom
Conversation
Also: - Validate with ShellCheck (Mainly reduce globbing) - Remove unnecessary directory access jumps with `cd` - `mkdir` should be enough. - Replace Read Parsing with automatic file checking - Checks for presence of `project.godot` file to determine if it is in a project root. - Change exit code for to non-zero value if not in a project root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started as a simple ShellCheck revision, but ballooned to include moving portions into function calls, and removing the user confirmation step.
Benefits:
cdcommands reduces disk read operations (negligible), and had room for potential issues.source {script}.sh; {function_name}){script}.sh --no-addons)Also updates the README.md